Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove obsolete GS testplan - it now lives in go-graphsync #7469

Merged
merged 1 commit into from
Oct 7, 2021
Merged

Remove obsolete GS testplan - it now lives in go-graphsync #7469

merged 1 commit into from
Oct 7, 2021

Conversation

ribasushi
Copy link
Collaborator

No description provided.

@ribasushi ribasushi requested a review from nonsense October 7, 2021 10:31
@ribasushi ribasushi marked this pull request as ready for review October 7, 2021 10:32
@ribasushi ribasushi requested a review from a team as a code owner October 7, 2021 10:32
@ribasushi
Copy link
Collaborator Author

A conversation with @nonsense revealed this is no longer an actively-relied-upon test. The motivation of purging it from lotus is the ancient go-ipld-prime dependency it relies on.

@codecov
Copy link

codecov bot commented Oct 7, 2021 •
edited
Loading

Codecov Report

Merging #7469 (7784831) into master (1993efe) will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7469      +/-   ##
==========================================
- Coverage   39.21%   39.15%   -0.07%     
==========================================
  Files         631      631              
  Lines       66787    66787              
==========================================
- Hits        26191    26148      -43     
- Misses      36024    36063      +39     
- Partials     4572     4576       +4
Impacted Files Coverage Δ
journal/types.go 86.66% <0.00%> (-13.34%) ⬇️
chain/events/observer.go 71.64% <0.00%> (-6.72%) ⬇️
chain/actors/builtin/paych/paych.go 14.77% <0.00%> (-4.55%) ⬇️
chain/exchange/peer_tracker.go 66.66% <0.00%> (-4.31%) ⬇️
node/hello/hello.go 63.63% <0.00%> (-3.41%) ⬇️
chain/store/store.go 62.66% <0.00%> (-2.84%) ⬇️
journal/fsjournal/fs.go 66.66% <0.00%> (-2.78%) ⬇️
miner/miner.go 55.29% <0.00%> (-2.32%) ⬇️
chain/sync_manager.go 66.77% <0.00%> (-0.63%) ⬇️
chain/messagepool/messagepool.go 56.93% <0.00%> (-0.62%) ⬇️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1993efe...7784831. Read the comment docs.

@magik6k magik6k merged commit 0ba88ac into master Oct 7, 2021
@magik6k magik6k deleted the chore/remove-obsolete-gs-testplan branch October 7, 2021 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magik6k magik6k magik6k approved these changes

@nonsense nonsense nonsense approved these changes

@hannahhoward hannahhoward Awaiting requested review from hannahhoward

@raulk raulk Awaiting requested review from raulk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ribasushi @nonsense @magik6k